lkml.org 
[lkml]   [2012]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 2/5] iommu/amd: Implement DOMAIN_ATTR_GEOMETRY attribute
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH 2/5] iommu/amd: Implement DOMAIN_ATTR_GEOMETRY attribute
Date: Thu, 19 Jan 2012 17:27:09 +0100
Message-ID: <201201191727.10176.laurent.pinchart@ideasonboard.com>

> Hi Joerg,
>
> On Thursday 19 January 2012 17:07:39 Joerg Roedel wrote:
> > On Thu, Jan 19, 2012 at 04:46:13PM +0100, Laurent Pinchart wrote:
> > > > +struct iommu_domain_geometry {
> > > > + u64 aperture_start; /* First address that can be mapped */
> > > > + u64 aperture_end; /* Last address that can be mapped */
> > >
> > > Would it make sense to use a platform-dependent type that represents
> > > physical addresses instead of u64 ?
> >
> > Well, u64 is a catch-all datatype which should suit all drivers. Is this
> > a problem at ARM?
>
> No, it's not a problem for ARM, at least to my knowledge. It just struck me as
> weird, as we have specific data types for other kinds of addresses (such as
> dma_addr_t).
>
> > We can also go the more complicated way of introducing an iova_addr_t or
> > something. But if possible I would like to avoid that.

"dma_addr_t" sounds nicer(and makes still sense) to me than a new "iova_addr_t".


\
 
 \ /
  Last update: 2012-01-20 06:47    [W:0.083 / U:3.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site