lkml.org 
[lkml]   [2012]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] cgroup: remove extra calls to find_existing_css_set
Tejun Heo (tj@kernel.org) wrote:
> On Tue, Jan 03, 2012 at 09:18:32PM -0800, Mandeep Singh Baines wrote:
> > +out_put_css_set_refs:
> > + if (retval) {
> > + for (i = 0; i < css_set_refs; i++) {
> > + tc = flex_array_get(group, i);
> > + put_css_set(tc->cg);
>
> Why not the following
>
> for (i = 0; i < group_size; i++) {
> tc = flex_array_get(group, i);
> if (tc)
> put_css_set(tc->cg);
> }
>
> and remove css_set_refs?
>

If I break out of step 2 via the goto (out_put_css_set_refs), I only
want to put back the refs I've gotten so far. I could reset group_size
in that case but wanted avoid overloading group_size: someone
could later add more error path code that isn't expecting that
group_size will get re-assigned and have its meaning change.

Regards,
Mandeep

> Thanks
>
> --
> tejun


\
 
 \ /
  Last update: 2012-01-21 04:01    [W:0.077 / U:5.684 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site