lkml.org 
[lkml]   [2012]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] Avoid mask based num_possible_cpus and num_online_cpus
>>> +int nr_online_cpus __read_mostly;
>>> +EXPORT_SYMBOL(nr_online_cpus);
>>> +
>>>  void set_cpu_possible(unsigned int cpu, bool possible)
>>>  {
>>>       if (possible)
>>
>>
>> Did you forget to add:
>>
>>        nr_possible_cpus = cpumask_weight(cpu_possible_mask);
>>
>> inside set_cpu_possible() ?
>
> No. That was intentional as I have that coupled with nr_cpu_ids and
> set once after all the bits are set in setup_nr_cpu_ids() instead of
> doing for each bit set.

But, Srivatsa's way seems more safer, no? Is there any advantage to make couple
with nr_cpu_ids?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-01-21 00:47    [W:0.085 / U:0.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site