lkml.org 
[lkml]   [2012]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] mfd: Add support for multiple s5m devices
On Fri, Jan 20, 2012 at 04:09:12PM +0900, Sangbeom Kim wrote:

Reviewed-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

> + switch (s5m87xx->device_type) {
> + case S5M8751X:
> + ret = mfd_add_devices(s5m87xx->dev, -1, s5m8751_devs,
> + ARRAY_SIZE(s5m8751_devs), NULL, 0);
> + break;

Does the hardware have ID registers you can use to confirm if the user
got the right device? Cut'n'pasting of machine definitions can be a bit
error prone.


\
 
 \ /
  Last update: 2012-01-20 19:25    [W:0.053 / U:2.976 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site