Messages in this thread | | | Date | Fri, 20 Jan 2012 18:23:04 +0000 | From | Mark Brown <> | Subject | Re: [PATCH 2/2] mfd: Add support for multiple s5m devices |
| |
On Fri, Jan 20, 2012 at 04:09:12PM +0900, Sangbeom Kim wrote:
Reviewed-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> + switch (s5m87xx->device_type) { > + case S5M8751X: > + ret = mfd_add_devices(s5m87xx->dev, -1, s5m8751_devs, > + ARRAY_SIZE(s5m8751_devs), NULL, 0); > + break;
Does the hardware have ID registers you can use to confirm if the user got the right device? Cut'n'pasting of machine definitions can be a bit error prone.
| |