Messages in this thread |  | | Date | Fri, 20 Jan 2012 22:22:14 +0400 | | From | Cyrill Gorcunov <> | | Subject | Re: [RFC] syscalls, x86: Add __NR_kcmp syscall |
| |
On Fri, Jan 20, 2012 at 10:19:54PM +0400, Cyrill Gorcunov wrote: > On Fri, Jan 20, 2012 at 08:57:11AM -0800, H. Peter Anvin wrote: > > On 01/20/2012 08:29 AM, Cyrill Gorcunov wrote: > > > > I would not worry about get_random_bytes() returning nothing... if > > so, a lot of other places in the kernel would be broken. > > > > Something like below? > > Cyrill > --- ... > + > +static __init int kcmp_cookie_init(void) > +{ > + int i, j; > + > + for (i = 0; i < KCMP_TYPES; i++) { > + for (j = 0; j < 2; j++) { > + get_random_bytes(&cookies[i][j], > + sizeof(cookies[i][j])); > + cookies[i][0] |= (~(~0UL >> 1) | 1);
Sigh, what a day. cookies[i][j]!
> + } > + } > + > + return 0; > +}
Cyrill
|  |