lkml.org 
[lkml]   [2012]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: AHCI_SHT(), ATA_BASE_SHT() and .can_queue
From
On Fri, Jan 20, 2012 at 5:36 PM, Tejun Heo <htejun@gmail.com> wrote:
> On Sat, Jan 14, 2012 at 05:04:21PM +0000, Bart Van Assche wrote:
>> I guess the fact that can_queue is specified twice and with different
>> values in AHCI_SHT() was unintentional ?
>
> Yes, it is intentional.  The macros provide default values which
> specific drivers or downstream class of drivers may choose to
> override.

Unfortunately sparse complains about that construct. It is annoying
when checking e.g. drivers/scsi with sparse to see sparse complain
many times about two different values being specified for .can_queue.
Should the sparse authors remove that warning ?

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-01-20 18:41    [W:0.028 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site