lkml.org 
[lkml]   [2012]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] kbuild: do not check for ancient modutils tools
On Wed, Jan 18, 2012 at 05:33, Cong Wang <amwang@redhat.com> wrote:
> On Tue, 2012-01-17 at 14:50 -0200, Lucas De Marchi wrote:
>> scripts/depmod.sh checks for the output of '-V' expecting that it has
>> module-init-tools in it. It's a hack to prevent users from using
>> modutils instead of module-init-tools, that only works with 2.4.x
>> kernels. This however prints an annoying warning for kmod tool, that is
>> currently replacing module-init-tools.
>>
>> Rather than putting another check for kmod's version, just remove it
>> since users of 2.4.x kernel are unlikely to upgrade to 3.x, and if they
>> do, let depmod fail in that case because they should know what they are
>> doing.
>>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi@profusion.mobi>
>
> Acked-by: WANG Cong <amwang@redhat.com>

Michal, mind picking this up? The warning it produces with kmod is
really misleading, and the check seems unnecessary these days.

Acked-By: Kay Sievers <kay.sievers@vrfy.org>

Thanks,
Kay


\
 
 \ /
  Last update: 2012-01-20 17:43    [W:0.049 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site