lkml.org 
[lkml]   [2012]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/5] iommu/amd: Implement DOMAIN_ATTR_GEOMETRY attribute
    On Thu, Jan 19, 2012 at 05:16:48PM +0000, Sethi Varun-B16395 wrote:
    > > struct iommu_domain {
    > > struct iommu_ops *ops;
    > > void *priv;
    > > iommu_fault_handler_t handler;
    > > + struct iommu_domain_geometry geometry;
    > > };
    > In case of our iommu implementation the iommu_domain_geometry would
    > include additional attributes. Why can't we let the geometry be
    > Implementation dependent?

    Because the values in this generic geometry-struct make sense for more
    than one IOMMU (short-term for Tegra GART and Freescale PAMU). If you
    have additional vendor-specific ones you could add them via a
    vendor-specific attribute.

    Regards,

    Joerg

    --
    AMD Operating System Research Center

    Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
    General Managers: Alberto Bozzo
    Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632



    \
     
     \ /
      Last update: 2012-01-20 17:07    [W:0.051 / U:61.680 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site