lkml.org 
[lkml]   [2012]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] ocfs2: use find_last_bit
    Date
    We already have find_last_bit. So just use it as described in the comment.

    Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
    Cc: Mark Fasheh <mfasheh@suse.com>
    Cc: Joel Becker <jlbec@evilplan.org>
    Cc: ocfs2-devel@oss.oracle.com
    ---
    fs/ocfs2/cluster/heartbeat.c | 18 ++----------------
    1 files changed, 2 insertions(+), 16 deletions(-)

    diff --git a/fs/ocfs2/cluster/heartbeat.c b/fs/ocfs2/cluster/heartbeat.c
    index cd36cb5..120fad9 100644
    --- a/fs/ocfs2/cluster/heartbeat.c
    +++ b/fs/ocfs2/cluster/heartbeat.c
    @@ -956,23 +956,9 @@ out:
    return changed;
    }

    -/* This could be faster if we just implmented a find_last_bit, but I
    - * don't think the circumstances warrant it. */
    -static int o2hb_highest_node(unsigned long *nodes,
    - int numbits)
    +static int o2hb_highest_node(unsigned long *nodes, int numbits)
    {
    - int highest, node;
    -
    - highest = numbits;
    - node = -1;
    - while ((node = find_next_bit(nodes, numbits, node + 1)) != -1) {
    - if (node >= numbits)
    - break;
    -
    - highest = node;
    - }
    -
    - return highest;
    + return find_last_bit(nodes, numbits);
    }

    static int o2hb_do_disk_heartbeat(struct o2hb_region *reg)
    --
    1.7.4.4


    \
     
     \ /
      Last update: 2012-01-20 16:17    [W:0.031 / U:1.780 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site