lkml.org 
[lkml]   [2012]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v5 6/8] fs: only send IPI to invalidate LRU BH when needed
    Date
    In several code paths, such as when unmounting a file system (but
    not only) we send an IPI to ask each cpu to invalidate its local
    LRU BHs.

    For multi-cores systems that have many cpus that may not have
    any LRU BH because they are idle or because they have no performed
    any file system access since last invalidation (e.g. CPU crunching
    on high perfomance computing nodes that write results to shared
    memory) this can lead to loss of performance each time someone
    switches KVM (the virtual keyboard and screen type, not the
    hypervisor) that has a USB storage stuck in.

    This patch attempts to only send the IPI to cpus that have LRU BH.

    Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
    CC: Christoph Lameter <cl@linux.com>
    CC: Chris Metcalf <cmetcalf@tilera.com>
    CC: Peter Zijlstra <a.p.zijlstra@chello.nl>
    CC: Frederic Weisbecker <fweisbec@gmail.com>
    CC: Russell King <linux@arm.linux.org.uk>
    CC: linux-mm@kvack.org
    CC: Pekka Enberg <penberg@kernel.org>
    CC: Matt Mackall <mpm@selenic.com>
    CC: Sasha Levin <levinsasha928@gmail.com>
    CC: Rik van Riel <riel@redhat.com>
    CC: Andi Kleen <andi@firstfloor.org>
    CC: Mel Gorman <mel@csn.ul.ie>
    CC: Andrew Morton <akpm@linux-foundation.org>
    CC: Alexander Viro <viro@zeniv.linux.org.uk>
    CC: linux-fsdevel@vger.kernel.org
    CC: Avi Kivity <avi@redhat.com>
    ---
    fs/buffer.c | 15 ++++++++++++++-
    1 files changed, 14 insertions(+), 1 deletions(-)

    diff --git a/fs/buffer.c b/fs/buffer.c
    index 19d8eb7..b2378d4 100644
    --- a/fs/buffer.c
    +++ b/fs/buffer.c
    @@ -1434,10 +1434,23 @@ static void invalidate_bh_lru(void *arg)
    }
    put_cpu_var(bh_lrus);
    }
    +
    +static int local_bh_lru_avail(int cpu, void *dummy)
    +{
    + struct bh_lru *b = per_cpu_ptr(&bh_lrus, cpu);
    + int i;

    + for (i = 0; i < BH_LRU_SIZE; i++) {
    + if (b->bhs[i])
    + return 1;
    + }
    +
    + return 0;
    +}
    +
    void invalidate_bh_lrus(void)
    {
    - on_each_cpu(invalidate_bh_lru, NULL, 1);
    + on_each_cpu_cond(local_bh_lru_avail, invalidate_bh_lru, NULL, 1);
    }
    EXPORT_SYMBOL_GPL(invalidate_bh_lrus);

    --
    1.7.0.4


    \
     
     \ /
      Last update: 2012-01-02 11:29    [W:3.857 / U:0.296 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site