lkml.org 
[lkml]   [2012]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] deadlock with suspend and quotas
    On Fri, Nov 25, 2011 at 03:25:16PM -0500, Mikulas Patocka wrote:

    > The following patch fixes the deadlock. When the quota subsystem takes s_umount,
    > it checks if the filesystem is frozen. If it is, we drop s_umount, wait for
    > the filesystem to resume and retry.
    >
    > Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
    > CC: stable@kernel.org

    So basically you want a variant of get_super() that would get you a
    superblock for this bdev, locked and unfrozen? Fair enough, but
    * that should be a proper helper in super.c, rather than
    open-coded in fs/quota/quota.c, of all places
    * what about other existing callers get_super() and its friends?

    and while we are at it, why in damnation name is it exported? The only
    caller outside of core VFS is under #if 0...


    \
     
     \ /
      Last update: 2012-01-03 04:33    [W:4.742 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site