lkml.org 
[lkml]   [2012]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/4] input: xilinx_ps2: Don't use NO_IRQ
    On Wed, Dec 21, 2011 at 03:32:11PM +0100, Michal Simek wrote:
    > Drivers shouldn't use NO_IRQ. Microblaze and PPC
    > define NO_IRQ as 0 and this reference will be removed
    > in near future.
    >
    > Signed-off-by: Michal Simek <monstr@monstr.eu>
    > CC: Grant Likely <grant.likely@secretlab.ca>
    > CC: Rob Herring <rob.herring@calxeda.com>
    > CC: Ryan Mallon <rmallon@gmail.com>

    Acked-by: Grant Likely <grant.likely@secretlab.ca>

    > ---
    > drivers/input/serio/xilinx_ps2.c | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/drivers/input/serio/xilinx_ps2.c b/drivers/input/serio/xilinx_ps2.c
    > index d64c5a4..f3e54b9 100644
    > --- a/drivers/input/serio/xilinx_ps2.c
    > +++ b/drivers/input/serio/xilinx_ps2.c
    > @@ -253,7 +253,7 @@ static int __devinit xps2_of_probe(struct platform_device *ofdev)
    > }
    >
    > /* Get IRQ for the device */
    > - if (of_irq_to_resource(ofdev->dev.of_node, 0, &r_irq) == NO_IRQ) {
    > + if (!of_irq_to_resource(ofdev->dev.of_node, 0, &r_irq)) {
    > dev_err(dev, "no IRQ found\n");
    > return -ENODEV;
    > }
    > --
    > 1.7.5.4
    >


    \
     
     \ /
      Last update: 2012-01-02 09:23    [W:0.036 / U:0.968 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site