Messages in this thread | | | Date | Mon, 2 Jan 2012 23:11:07 +0530 | Subject | Re: [RFC][PATCH 2/4] lcd: platform-lcd: Add support for Hydis hv070wsa lcd panel | From | Thomas Abraham <> |
| |
Hi Mark,
On 2 January 2012 17:15, Mark Brown <broonie@opensource.wolfsonmicro.com> wrote: > On Mon, Jan 02, 2012 at 11:24:33AM +0530, Thomas Abraham wrote: > >> +static void lcd_hv070wsa_set_power(struct platform_lcd *plcd, unsigned int pwr) >> +{ >> + struct plat_lcd_hydis_hv070wsa_pdata *pdata = plcd->lcd_pdata; >> + >> + gpio_direction_output(pdata->gpio, pwr); >> +} > > This doesn't look at all specific to this panel - it's just setting a > GPIO - so it should probably just be a generic gpio-lcd driver (or > similar). It ought to be possible to do a device tree binding for at > least this subset of panels.
Right. I should not have made it specific to hv070wsa panel. This type of functionality is reusable for other lcd panels as well. I will modify this patch.
Thanks, Thomas. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |