lkml.org 
[lkml]   [2012]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 01/12] blkcg: obtaining blkg should be enclosed inside rcu_read_lock()
    On Thu, Jan 19, 2012 at 10:54:45AM -0500, Vivek Goyal wrote:
    > > No, no matter whatever synchronization scheme is in use, the code is
    > > seriously screwed up if it's doing something like,
    > >
    > > lock();
    > > a = lookup();
    > > unlock();
    > > return a;
    > >
    > > You should *NEVER* be doing that.
    >
    > I guess ioc_lookup_icq() is doing something similar. We call it under
    > queue lock. Take rcu lock inside for sanity of radix tree and then
    > release rcu lock and return icq.

    Yeap, it is. We should be using rcu_dereference_check() there too.

    Thanks.

    --
    tejun


    \
     
     \ /
      Last update: 2012-01-19 17:01    [W:0.020 / U:62.732 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site