lkml.org 
[lkml]   [2012]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: Pinmux bindings proposal
Shawn Guo wrote at Tuesday, January 17, 2012 8:32 PM:
> On Tue, Jan 17, 2012 at 10:47:14AM -0800, Stephen Warren wrote:
> > Shawn Guo wrote at Saturday, January 14, 2012 12:09 AM:
> > > On Fri, Jan 13, 2012 at 12:39:42PM -0800, Stephen Warren wrote:
...
> > > > /*
> > > > * The actual definition of the complete state of the
> > > > * pinmux as required by some driver.
> > > > *
> > > > * These can be either directly in the device node, or
> > > > * somewhere in tegra20.dtsi in order to provide pre-
> > > > * selected/common configurations. Hence, they're referred
> > > > * to by phandle above.
> > > > */
> > > > pmx_sdhci_active: {
> > > > /*
> > > > * Pin mux settings. Mandatory?
> > > > * Not mandatory if the 1:1 mentioned above is
> > > > * extended to 1:n.
> > > > *
> > > > * Format is <&pmx_controller_phandle muxable_entity_id
> > > > * selected_function>.
> > > > *
> > > > * The pmx phandle is required since there may be more
> > > > * than one pinmux controller in the system. Even if
> > > > * this node is inside the pinmux controller itself, I
> > > > * think it's simpler to just always have this field
> > > > * present in the binding for consistency.
> > > > *
> > >
> > > I prefer to just put such nodes inside pinctrl controller itself and
> > > drop those phandles.
> >
> > My rationale here:
> >
> > Forcing those nodes to be inside the controller node forces us to store
> > any board-specific custom configurations or overrides in the controller
> > node too; I'd simply prefer the flexibility to put them anywhere.
>
> Hmm, this type of flexibility does not make too much point to me. On
> the contrary, it's good to have a centralized place for these nodes,
> so that they can be well organized and people can find them easily.

I still would really rather have the flexibility to just put the nodes
anywhere.

However, I don't think we lose any functionality by forcing the nodes
to be inside the pin controller's node. And as you say, we do get to
remove the phandle from the mux and config properties then too, which
very marginally simplifies parsing.

One other concern I had was a device that needed to configure the pin
mux on two different pin controllers (think the main SoC and some complex
chip attached to one of the SoC's external busses). Ideally, there'd be
a Linux device for each end of the bus, and each would configure the
respective chip's pinmux. However, I can certainly foresee cases where
there's only a Linux device for the main SoC, and it'd need to configure
both chips' pinmux. Still, I think we can deal with that easily enough,
since that device's pinctrl property can simply use the 1:n feature, and
have multiple entries pointing at both chip's pinctrl device:

foo@c8000200 {
...
pinctrl = <&pinmux_soc_xxx> <&pinmux_otherchip_xxx>
<&pinmux_soc_xxx_suspend> <&pinmux_otherchip_xxx_suspend>;
pinctrl-entries = <2 2>;
pinctrl-names = "active", "suspend";
};

So, I can live with requiring the pin configuration nodes to be underneath
the relevant pin controller's node, and removing the phandle from the
mux and config properties in the pin configuration nodes.

--
nvpublic



\
 
 \ /
  Last update: 2012-01-18 20:03    [W:0.105 / U:0.484 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site