Messages in this thread | | | From | Stephen Warren <> | Date | Wed, 18 Jan 2012 09:54:27 -0800 | Subject | RE: [PATCH V1 2/2] regulator: tps65910: Initialize n_voltages for rails. |
| |
Laxman Dewangan wrote at Wednesday, January 18, 2012 8:17 AM: > Initializing the number of voltages supported by different > rails of pmic device tps65911. ... > diff --git a/drivers/regulator/tps65910-regulator.c b/drivers/regulator/tps65910-regulator.c ... > @@ -188,56 +188,67 @@ static struct tps_info tps65911_regs[] = { > .name = "VDD1", > .min_uV = 600000, > .max_uV = 4500000, > + .table_len = 73, > },
Forgive me if these comments are bogus since I'm not familiar with regulators much, but:
a) Don't you want to use ARRAY_SIZE() instead of hard-coding table_len's value?
b) Don't you need to set .table to actually point at the table too? If not, isn't tps65910_list_voltage() going to dereference a NULL pointer, since it will dereference .table if .table_len is set?
-- nvpublic
| |