lkml.org 
[lkml]   [2012]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][GIT PULL][v3.3] tracing: Add header wrappers event_headers_start.h and event_headers_end.h

* Steven Rostedt <rostedt@goodmis.org> wrote:

> On Tue, 2012-01-17 at 10:54 +0100, Ingo Molnar wrote:
> > * Steven Rostedt <rostedt@goodmis.org> wrote:
> >
>
> > Hm, i don't really like the extra complexity - this code
> > *really* does not need any more complexity ...
>
> I agree.
>
> >
> > How about the low-tech solution of adding some text between
> > '/* */' markers to warns that these headers should not be
> > included in ordinary headers?
>
> The problem is that they currently are. For example:
>
> include/linux/interrupt.h
>
> has one to add a tracepoint in __raise_softirq_irqoff()
>
> Which is fine, as long as no other tracepoint header includes
> linux/interrupt.h.

Could we try to remove this one from the header?

I'd argue that __raise_softirq_irqoff() should not be inline -
that would solve a whole host of issues. Event tracing is
enabled in most distros so there's no real overhead argument to
be made here either - so it's probably a bit faster in fact to
have this uninlined. What do you think?

Thanks,

Ingo


\
 
 \ /
  Last update: 2012-01-18 13:09    [W:0.114 / U:0.748 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site