lkml.org 
[lkml]   [2012]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] amba-pl011: clear previous interrupts before request_irq
>  	/*
> + * Clear previous interrupts before installing interrupt handler
> + */
> + spin_lock_irq(&uap->port.lock);
> + uap->im = 0;
> + writew(uap->im, uap->port.membase + UART011_IMSC);
> + writew(0xffff, uap->port.membase + UART011_ICR);
> + spin_unlock_irq(&uap->port.lock);

I'm confused why you use spin_lock_irq before you've enabled the IRQ in
the first place but looks fine.

Alan


\
 
 \ /
  Last update: 2012-01-18 12:43    [W:0.079 / U:1.804 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site