Messages in this thread | | | Date | Tue, 17 Jan 2012 23:57:39 -0500 (EST) | Subject | Re: [PATCH] Fix panic in __d_lookup with high dentry hashtable counts | From | David Miller <> |
| |
From: Dimitri Sivanich <sivanich@sgi.com> Date: Tue, 17 Jan 2012 15:05:41 -0600
> On Tue, Jan 17, 2012 at 12:22:29PM -0500, David Miller wrote: >> To be honest I think this is overkill. >> >> Supporting anything larger than a 32-bit hash mask is not even close >> to being reasonable. Nobody needs a 4GB hash table, not for anything. >> > Here is a patch that keeps the 32-bit hash mask. > > > > When the number of dentry cache hash table entries gets too high > (2147483648 entries), as happens by default on a 16TB system, use > of a signed integer in the dcache_init() initialization loop prevents > the dentry_hashtable from getting initialized, causing a panic in > __d_lookup(). Fix this in dcache_init() and similar areas. > > Signed-off-by: Dimitri Sivanich <sivanich@sgi.com>
This looks good to me, thanks Dimitri:
Acked-by: David S. Miller <davem@davemloft.net>
| |