lkml.org 
[lkml]   [2012]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Intel-gfx] [PATCH] drm/i915: set AUD_CONFIG N_value_index for DisplayPort
On Tue, Jan 17, 2012 at 07:08:09AM +0800, Wu Fengguang wrote:
> On Mon, Jan 16, 2012 at 12:44:43PM -0800, Keith Packard wrote:
> > On Mon, 16 Jan 2012 21:26:18 +0100, Daniel Vetter <daniel@ffwll.ch> wrote:
> >
> > > Keith, does this address your concern and this patch is r-b: Keith or do
> > > we want an
> > >
> > > } else {
> > > I915_WRITE(aud_config, 0);
> > > }
> > >
> > > for paranoia?
> >
> > I think we want this added, just to be sure we set the configuration
> > correctly in all cases; it's easy to imagine moving from DP to HDMI and
> > leaving this bit set.
>
> Ah good point! Here is the updated patch.
>
> ---
> Subject: drm/i915: set AUD_CONFIG N_value_index for DisplayPort
> Date: Fri Jan 06 14:41:31 CST 2012
>
> It should be programmed to "0" for HDMI or "1" for DisplayPort.
>
> This enables DisplayPort audio for
>
> - HP EliteBook 8460p
> (whose BIOS does not set the N_value_index bit for us)
>
> - DisplayPort monitor hot plugged after boot
> (otherwise most BIOS will fill the N_value_index bit for us)
>
> Tested-by: Robert Lemaire <rlemaire@suse.com>
> Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>

I've tried to apply this patch but it has a conflict in i915_reg.h (with
the SOL reset stuff). Care to rebase and resend? Also, git patches as
produced by git format-patch highly preferred.

Thanks, Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48


\
 
 \ /
  Last update: 2012-01-17 11:25    [W:0.081 / U:0.800 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site