Messages in this thread |  | | Date | Tue, 17 Jan 2012 15:55:52 -0800 | | From | Andrew Morton <> | | Subject | Re: [PATCH v4] ramoops: use pstore interface |
| |
On Tue, 17 Jan 2012 15:48:25 -0800 Kees Cook <keescook@chromium.org> wrote:
> > Note that pstore_get_records() will treat the -ve errno returns from > > ->read() in the same manner as EOF. IOW, your error codes will be > > dropped on the floor. This appears to be a bug in pstore_get_records(). > > Well, IIUC, it just means the file doesn't get populated at all; there > is no userspace interface to finding out why a file didn't appear in > the pstore fliesystem. But yes, the specifics of the error are ignored > by pstore_get_records(). It didn't seem wrong to produce meaningful > codes in ramoops, though. >
Well, there's a printk() in there. But it only comes out if it was pstore_mkfile() which failed. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |