lkml.org 
[lkml]   [2012]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/2 v2] gpio-pch: cleanup __iomem annotation usage
    From: Márton Németh <nm127@freemail.hu>

    The __iomem annotation is to be used together with pointers used
    as iowrite32() parameter. For more details see [1] and [2].

    This patch will remove the following sparse warnings ("make C=1"):
    * warning: incorrect type in assignment (different address spaces)
    * warning: incorrect type in argument 1 (different address spaces)
    * warning: incorrect type in argument 2 (different address spaces)

    References:
    [1] A new I/O memory access mechanism (Sep 15, 2004)
    http://lwn.net/Articles/102232/

    [2] Being more anal about iospace accesses (Sep 15, 2004)
    http://lwn.net/Articles/102240/

    Signed-off-by: Márton Németh <nm127@freemail.hu>
    Cc: Grant Likely <grant.likely@secretlab.ca>
    Cc: Linus Walleij <linus.walleij@linaro.org>
    ---
    drivers/gpio/gpio-pch.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/gpio/gpio-pch.c b/drivers/gpio/gpio-pch.c
    index f060329..8f101b3 100644
    --- a/drivers/gpio/gpio-pch.c
    +++ b/drivers/gpio/gpio-pch.c
    @@ -231,7 +231,7 @@ static void pch_gpio_setup(struct pch_gpio *chip)
    static int pch_irq_type(struct irq_data *d, unsigned int type)
    {
    u32 im;
    - u32 *im_reg;
    + void __iomem *im_reg;
    u32 ien;
    u32 im_pos;
    int ch;
    --
    1.7.2.5
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2012-01-17 21:47    [W:0.021 / U:32.784 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site