Messages in this thread |  | | Date | Tue, 17 Jan 2012 12:03:17 -0800 | | From | Greg KH <> | | Subject | Re: [PATCH v2 2/3] block: fail SCSI passthrough ioctls on partition devices |
| |
On Sat, Jan 14, 2012 at 03:43:01PM -0800, Linus Torvalds wrote: > On Thu, Jan 12, 2012 at 7:01 AM, Paolo Bonzini <pbonzini@redhat.com> wrote: > > + case CDROM_GET_CAPABILITY: > > + /* Keep this until we remove the printk below. udev sends it > > + * and we do not want to spam dmesg about it. CD-ROMs do > > + * not have partitions, so we get here only for disks. > > + */ > > + return -ENOIOCTLCMD; > > Looks like CDROMMULTISESSION is another of these. > > I get two of these: > > mount: sending ioctl 5310 to a partition! > > with Fedora 14 whenever a USB stick is inserted (I changed your patch > to also print the name of the program). Let's see if anything else > pops up. > > Anyway, with the changes to print out warnings and still allow it for > root, this all looked safe and nice, so they are in my tree now. I > only noticed after applying them that you hadn't marked them with 'cc: > stable@kernel.org', so we should probably point Greg at them. They are > commits > > 577ebb374c78 block: add and use scsi_blk_cmd_ioctl > 0bfc96cb7722 block: fail SCSI passthrough ioctls on partition devices > ec8013beddd7 dm: do not forward ioctls from logical volumes to the > underlying device > > in my tree now.
Thanks, I've queued them all up for the 3.2 and 3.0-stable trees.
greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |