lkml.org 
[lkml]   [2012]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] vsprintf: Prevent NULL dereference using %pNF
    From
    Date
    On Tue, 2012-01-17 at 13:52 -0500, David Miller wrote:
    > From: Joe Perches <joe@perches.com>
    > Date: Tue, 17 Jan 2012 10:51:13 -0800
    >
    > > On Tue, 2012-01-17 at 13:46 -0500, David Miller wrote:
    > >> From: Joe Perches <joe@perches.com>
    > >> Date: Tue, 17 Jan 2012 10:37:13 -0800
    > >> > Passing NULL to %pNF is done in skb_gso_segment
    > >> > which could be dereferenced.
    > >> skb_gso_segment() should be fixed instead.
    > >
    > > Maybe. Dereferencing NULL is bad form.
    >
    > We don't check for NULL for IPV4 or IPV6 addresses,

    Because we don't pass NULL addresses.

    > no reason
    > to treat this any differently.

    A NULL address is specifically passed here.

    > Either do it for all %pX things, or none of them.

    Maybe.



    \
     
     \ /
      Last update: 2012-01-17 19:57    [W:0.018 / U:30.720 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site