Messages in this thread | | | Date | Tue, 17 Jan 2012 08:28:50 -0800 | From | Greg KH <> | Subject | Re: [PATCH] mce: fix warning messages about static struct mce_device |
| |
On Tue, Jan 17, 2012 at 07:51:25AM -0800, Greg KH wrote: > On Tue, Jan 17, 2012 at 09:38:43AM +0100, Ingo Molnar wrote: > > > > * Greg KH <gregkh@suse.de> wrote: > > > > > diff --git a/arch/x86/include/asm/mce.h b/arch/x86/include/asm/mce.h > > > index f35ce43..6aefb14 100644 > > > --- a/arch/x86/include/asm/mce.h > > > +++ b/arch/x86/include/asm/mce.h > > > @@ -151,7 +151,7 @@ static inline void enable_p5_mce(void) {} > > > > > > void mce_setup(struct mce *m); > > > void mce_log(struct mce *m); > > > -DECLARE_PER_CPU(struct device, mce_device); > > > +extern struct device *mce_device[CONFIG_NR_CPUS]; > > > > Minor nit, i don't think we have any other such [CONFIG_NR_CPUS] > > pattern in the kernel. > > > > This should be something like: > > > > DECLARE_PER_CPU(struct device *, mce_device); > > That is what we used to have, but with just a static struct device. We > really don't need this to be in the per-cpu area, a flat array should be > just fine, why can't we use the CONFIG_NR_CPUS value? Should we use > something else? > > > Or the pointer should be attached to the CPU info structure. > > Ok, I have no objection to that, do you want me to make a patch doing > that, now that this is already in Linus's tree?
Wait, isn't that variable also used in head.S, so do you really want a struct device * in there?
thanks,
greg k-h
| |