Messages in this thread | | | Date | Tue, 17 Jan 2012 07:37:27 +0100 | Subject | Re: [29/48] HID: wiimote: Select INPUT_FF_MEMLESS | From | David Herrmann <> |
| |
On Tue, Jan 17, 2012 at 2:55 AM, Paul Gortmaker <paul.gortmaker@windriver.com> wrote: > On Mon, Jan 16, 2012 at 1:44 PM, Greg KH <gregkh@suse.de> wrote: >> 3.1-stable review patch. If anyone has any objections, please let me know. > > This one looks like typical patch Makefile/Kconfig "oh, hey this fits anywhere" > nonsense, and is completely broken. Original was for a Wiimote, not Wacom. >
Could someone explain to me where this came from? I cannot remember writing this patch. I wrote this one: http://git.kernel.org/?p=linux/kernel/git/jikos/hid.git;a=commitdiff;h=ef6f41157f3864d9bf42671b2ed66062dcafb72e
I don't know where you got this "From" line?
Regards David
> >> >> ------------------ >> >> From: David Herrmann <dh.herrmann@googlemail.com> >> >> commit ef6f41157f3864d9bf42671b2ed66062dcafb72e upstream. >> >> We depend on memless force-feedback support, therefore correctly select the >> related config options. >> >> Reported-by: Randy Dunlap <rdunlap@xenotime.net> >> Signed-off-by: David Herrmann <dh.herrmann@googlemail.com> >> Signed-off-by: Jiri Kosina <jkosina@suse.cz> >> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> >> >> --- >> drivers/hid/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> --- a/drivers/hid/Kconfig >> +++ b/drivers/hid/Kconfig >> @@ -583,6 +583,7 @@ config HID_WACOM_POWER_SUPPLY >> bool "Wacom Bluetooth devices power supply status support" >> depends on HID_WACOM >> select POWER_SUPPLY >> + select INPUT_FF_MEMLESS >> ---help--- >> Say Y here if you want to enable power supply status monitoring for >> Wacom Bluetooth devices. >> >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |