Messages in this thread | | | Date | Tue, 17 Jan 2012 09:59:13 -0200 | From | Marcelo Tosatti <> | Subject | Re: [PATCH 3/3] KVM: perf: kvm events analysis tool |
| |
On Mon, Jan 16, 2012 at 10:08:40AM +0000, Stefan Hajnoczi wrote: > On Mon, Jan 16, 2012 at 9:32 AM, Xiao Guangrong > <xiaoguangrong@linux.vnet.ibm.com> wrote: > > +DESCRIPTION > > +----------- > > +You can analyze some crucial events and statistics with this > > +'perf kvm-events' command. > > This line is very general and does not explain which events/statistics > can be collected or how you can use that information. I suggest > making this description more specific. Explain that this subcommand > observers kvm.ko tracepoints and annotates/decodes them with > additional information (this is why I would use this command and not > raw perf record -e kvm:\*). > > > + { SVM_EXIT_MONITOR, "monitor" }, \ > > + { SVM_EXIT_MWAIT, "mwait" }, \ > > + { SVM_EXIT_XSETBV, "xsetbv" }, \ > > + { SVM_EXIT_NPF, "npf" } > > All this copy-paste could be avoided by sharing this stuff with the > arch/x86/kvm/ code.
Yes, same for KVM_MAX_VCPUS.
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |