lkml.org 
[lkml]   [2012]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v9 3.2 7/9] tracing: uprobes trace_event interface

Srikar, rebased commits like this one:

c5af743: rcu: Introduce raw SRCU read-side primitives

are absolutely inacceptable:

commit c5af7439f322db86e347991e184b95dd80676967
Author: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Date: Sun Oct 9 15:13:11 2011 -0700

rcu: Introduce raw SRCU read-side primitives

...

Requested-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Tested-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>

If you pull a commit from Paul into your tree then you must
never rebase it. If you applied Paul's commit out of email then
you should add a Signed-off-by, not a Tested-by tag at the end.

Also, please test whether it works when merged to latest -tip,
there's been various RCU changes in this area. AFAICS these
read-side primitives are already upstream via:

0c53dd8b3140: rcu: Introduce raw SRCU read-side primitives

so pulling your tree would break the build.

Thanks,

Ingo


\
 
 \ /
  Last update: 2012-01-17 12:25    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean