lkml.org 
[lkml]   [2012]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 2/7] ftrace: Add enable/disable ftrace_ops control interface
    From
    Date
    On Tue, 2012-01-17 at 02:42 +0100, Frederic Weisbecker wrote:
    >
    > > diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h
    > > index 523640f..0d43a2b 100644
    > > --- a/include/linux/ftrace.h
    > > +++ b/include/linux/ftrace.h
    > > @@ -35,12 +35,14 @@ enum {
    > > FTRACE_OPS_FL_ENABLED = 1 << 0,
    > > FTRACE_OPS_FL_GLOBAL = 1 << 1,
    > > FTRACE_OPS_FL_DYNAMIC = 1 << 2,
    > > + FTRACE_OPS_FL_CONTROL = 1 << 3,
    >
    > Please comment the role of this flag. In fact it would be nice to have
    > a comment that explains all these. GLOBAL and DYNAMIC don't actually give
    > much clues alone.

    Someone else asked about commenting these (was it you?). I probably
    should, as it is confusing to what they are used for.

    I just figured every just figures it out by looking at the code ;-)

    -- Steve




    \
     
     \ /
      Last update: 2012-01-17 03:11    [W:0.022 / U:29.308 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site