Messages in this thread | | | Date | Mon, 16 Jan 2012 16:49:06 -0500 (EST) | From | Alan Stern <> | Subject | Re: 3.2.0-07927-gc49c41a: s2ram: Device 'machinecheck1' does not have a release() function, it is broken and must be fixed |
| |
On Mon, 16 Jan 2012, Rafael J. Wysocki wrote:
> On Monday, January 16, 2012, Srivatsa S. Bhat wrote:
> > Just to re-instate, an end-user need not really worry about this warning > > too much since this was there before (at a different place, and hidden) > > when things were working fine... Hence it would be worthwhile to fix > > this warning "correctly" if possible, than just do a quick and dirty > > "silence the warning" kind of workaround. > > Well, since there's nothing to release in there, I really see only two > possible "fixes": either silence the warning the way you describe, or > remove it from the core.
No, the right fix is to release something. The device structures should be allocated dynamically, not statically. Greg's suggestion of using a set of per-cpu pointers to dynamically-allocated structures sounds right.
Alan Stern
| |