lkml.org 
[lkml]   [2012]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [GIT PULL] Block drivers for 3.3-rc
    Date
    > On 2012-01-15 11:33, Christoph Hellwig wrote:
    > > On Sun, Jan 15, 2012 at 10:52:12AM +0100, Jens Axboe wrote:
    > >> Hi Linus,
    > >>
    > >> Please see below for the 3.3-rc1 block driver pull request.
    > >>
    > >> Essentially two different categories here:
    > >>
    > >> - Adds the driver for the Micron RealSSD P320 pci-express flash card.
    > >
    > > The REQ_FUA and REQ_FLUSH handling in it is still completely broken,
    > > with no attempt to fix it since it last came up.
    > >
    > > So a pretty clear NAK on that driver from me.
    >
    > Good point, I had forgotten about the ordered writes, I believe the rest
    > of the items have been handled. The driver/hw, as it stands, does not
    > reorder writes and it doesn't have a write back cache. So it should
    > actually be safe. Any acked write is stable. Sam, correct me if I'm
    > wrong.

    That's correct, Jens. Neither the driver nor the hardware reorders commands so we choose to ignore barriers. I see now that the "barrier" parameter in the function is rather unfortunately named. We'll fix that.

    -Sam


    \
     
     \ /
      Last update: 2012-01-16 20:23    [W:0.025 / U:30.640 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site