Messages in this thread | | | From | Štefan Gula <> | Date | Mon, 16 Jan 2012 15:47:38 +0100 | Subject | Re: [patch v1, kernel version 3.2.1] net/ipv4/ip_gre: Ethernet multipoint GRE over IP |
| |
Dňa 16. januára 2012 15:25, Eric Dumazet <eric.dumazet@gmail.com> napísal/a: > Le lundi 16 janvier 2012 à 15:05 +0100, Štefan Gula a écrit : >> Dňa 16. januára 2012 14:19, Eric Dumazet <eric.dumazet@gmail.com> napísal/a: > >> > Unfortunately you call ipgre_tap_bridge_get() from >> > ipgre_tap_bridge_get_raddr() but you dont release the refcount on >> > use_count. Leak in ipgre_tunnel_xmit() >> > >> > >> >> +__be32 ipgre_tap_bridge_get_raddr(struct ip_tunnel *tunnel, >> >> + const unsigned char *addr) >> >> +{ >> >> + struct ipgre_tap_bridge_entry *entry; >> >> + entry = ipgre_tap_bridge_get(tunnel, addr); >> > >> > So maybe you want __ipgre_tap_bridge_get(tunnel, addr); here ? >> > >> Hmmm.. I am sorry, I am maybe not that expert on C coding, as most of >> the codes were copied from linux bridge code. Can you give me a hint >> how should I change that? > > I dont see in net/bridge the code you copied. > > Could you give more information ? > >
File: net/birdge/br_fdb.c Functions: __br_fdb_get br_fdb_get My analogy fuctions: __ipgre_tap_bridge_get ipgre_tap_bridge_get
-- Stefan Gula -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |