lkml.org 
[lkml]   [2012]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH 2/2] hwmon: (w83627ehf) Add GPIO port 3 functionality
On Sat, 14 Jan 2012 16:15:08 -0600, Alejandro wrote:
> On 14-Jan-12 2:18 PM, Jean Delvare wrote:
> > This is calling for a MFD driver for these chips. This was proposed in
> > the past, BTW, but never followed up:
> > http://lists.lm-sensors.org/pipermail/lm-sensors/2010-February/027795.html
> >
> > Putting everything in the current driver is not going to be accepted.
> > It certainly looks pleasant because it's a more simple approach, but
> > the result would be a complex and unmaintainable driver.
>
> The patch looks great, and it is definitely more maintainable. I'll
> create a patch for the w83627ehf driver and send it as soon as possible.
> Should I make the patch for the w83627hf or wait for Rodolfo???

Despite the similar names, these drivers are independent, they don't
have to be converted at the same time. So just do what you need for
yourself.

To be honest I thought that w83627ehf was the driver Rudolfo had
attempted to convert, not w83627hf. I remembered incorrectly. But at
least it gives you an idea of how the conversion should be done. Note
that Rudolfo's work wasn't properly reviewed (otherwise it would be
upstream by now) so I can't guarantee it's 100% correct, but at least
the mfd structure should be good enough to use as an example.

--
Jean Delvare


\
 
 \ /
  Last update: 2012-01-15 09:19    [W:0.064 / U:3.336 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site