Messages in this thread | | | Date | Sat, 14 Jan 2012 14:19:11 -0600 | From | Larry Finger <> | Subject | Re: [PATCH V2] rtl8192cu: Fix WARNING on suspend/resume |
| |
John,
Please drop the patch with this subject. I think I can do a better job than this.
Larry
Commit message:
============================================= A recent LKML thread (http://lkml.indiana.edu/hypermail/linux/kernel/1112.3/00965.html) discusses warnings that occur during a suspend/resume cycle. The driver attempts to read the firmware file before userspace is ready, leading to the following warning:
WARNING: at drivers/base/firmware_class.c:537 _request_firmware+0x3f6/0x420()
For rtl8192cu, the problem is fixed by storing the firmware in a global buffer rather than one allocated per device. The usage count is increased when suspending and decreased when resuming. This way, the firmware is retained through a suspend/resume cycle, and does not have to be reread.
This patch should fix the bug reported in https://bugzilla.redhat.com/show_bug.cgi?id=771002.
Note: This patch also touches rtl8192ce as the "firmware" loaded message is now printed in the wrong place.
Reported-by: Mohammed Arafa <bugzilla@in-egypt.net> Reported-by: Dave Jones <davej@redhat.com> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Stable <stable@vger.kernel.org> ---
V2 - revised to avoid warning noted by Daniel Halperin. ---
| |