Messages in this thread | | | Date | Sun, 15 Jan 2012 01:09:20 +0100 | From | Daniel Vetter <> | Subject | Re: [PATCH] gpu, drm, sis: Don't return uninitialized variable from sis_driver_load() |
| |
On Sat, Jan 14, 2012 at 09:20:37PM +0100, Jesper Juhl wrote: > In sis_driver_load(), the only use of 'ret' is as the return value > from the function, unfortunately it is never initialized, so the > function just returns garbage when it succeeds. > To fix that, remove the variable and just return 0 directly on success. > > Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Woot, not one of mine!
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48
| |