lkml.org 
[lkml]   [2012]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix race in process_vm_rw_core
On Fri, 13 Jan 2012 14:30:50 -0800
Andrew Morton <akpm@linux-foundation.org> wrote:
> > +struct mm_struct *get_check_task_mm(struct task_struct *task,
> > unsigned int mode) +{
> > + struct mm_struct *mm;
> > + int err;
> > +
> > + err =
> > mutex_lock_killable(&task->signal->cred_guard_mutex);
> > + if (err)
> > + return ERR_PTR(err);
> > +
> > + task_lock(task);
> > + if (__ptrace_may_access(task, mode)) {
> > + mm = ERR_PTR(-EACCES);
> > + goto out;
> > + }
> > +
> > + mm = task->mm;
> > + if (mm) {
> > + if (task->flags & PF_KTHREAD)
> > + mm = NULL;
> > + else
> > + atomic_inc(&mm->mm_users);
> > + }
> > +
> > +out:
> > + task_unlock(task);
> > + mutex_unlock(&task->signal->cred_guard_mutex);
> > +
> > + return mm;
> > +}
> > +EXPORT_SYMBOL_GPL(get_check_task_mm);
>
> I don't think the export is needed - CONFIG_PROC_FS=m isn't supported.

ok.

> btw, I'm trying to work out why we didn't make the whole
> process_vm_access.o feature Kconfigurable, so people who don't want
> it do not get burdened with it?

I don't know. I'll make this change if you'd like but I won't have time
to do it before leaving for LCA tomorrow. Have a toddler about to arrive
at my house.

Chris
--
cyeoh@au.ibm.com



\
 
 \ /
  Last update: 2012-01-14 00:33    [W:0.850 / U:0.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site