lkml.org 
[lkml]   [2012]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] backlight: Fix the logic to set bits in adp8860_bl and adp8870_bl drivers
    From
    Date
    We need to write new value if the bit mask fields of new value is not equal to
    old value. It does not make sense to write new value only when all the bit_mask
    bits are zero.

    Signed-off-by: Axel Lin <axel.lin@gmail.com>
    ---
    drivers/video/backlight/adp8860_bl.c | 2 +-
    drivers/video/backlight/adp8870_bl.c | 2 +-
    2 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c
    index 66bc74d..378276c 100644
    --- a/drivers/video/backlight/adp8860_bl.c
    +++ b/drivers/video/backlight/adp8860_bl.c
    @@ -146,7 +146,7 @@ static int adp8860_set_bits(struct i2c_client *client, int reg, uint8_t bit_mask

    ret = adp8860_read(client, reg, &reg_val);

    - if (!ret && ((reg_val & bit_mask) == 0)) {
    + if (!ret && ((reg_val & bit_mask) != bit_mask)) {
    reg_val |= bit_mask;
    ret = adp8860_write(client, reg, reg_val);
    }
    diff --git a/drivers/video/backlight/adp8870_bl.c b/drivers/video/backlight/adp8870_bl.c
    index 6c68a68..6735059 100644
    --- a/drivers/video/backlight/adp8870_bl.c
    +++ b/drivers/video/backlight/adp8870_bl.c
    @@ -160,7 +160,7 @@ static int adp8870_set_bits(struct i2c_client *client, int reg, uint8_t bit_mask

    ret = adp8870_read(client, reg, &reg_val);

    - if (!ret && ((reg_val & bit_mask) == 0)) {
    + if (!ret && ((reg_val & bit_mask) != bit_mask)) {
    reg_val |= bit_mask;
    ret = adp8870_write(client, reg, reg_val);
    }
    --
    1.7.5.4




    \
     
     \ /
      Last update: 2012-01-13 09:19    [W:0.022 / U:359.756 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site