[lkml]   [2012]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Subject[PATCH 0/8] cgroups: Task counter subsystem v7

    This is the task counter limitation patchset rebased on top
    of Tejun's latest cgroup tree (cgroup/for-3.3). In a later
    iteration, I also intend to include its selftests once the
    selftest subsystem is merged after -rc1.

    In fact, the rebase mostly is a concern of the last patch. The
    others haven't changed except a few unnoticeable dusts. Some patches
    have also been removed because either the last cgroup patches cover
    what they were doing or they were tiny changes I merged in the last
    patch (like a missing include of err.h fixed by Stephen Rothwell).

    Please note that Andrew Morton had doubts whether we want to merge
    it upstream or not. So don't merge it too eagerly before we sort out
    the debate.

    = What is this ? =

    The task counter subsystem counts the tasks inside a cgroup and
    rejects forks and cgroup migration when they result in a number
    of task above the user tunable limit.

    = Why is this needed ? =

    We want to be able to run untrustee programs into sandboxes and
    secure containers while protecting against forkbombs.

    This patchset allow us to:

    1) Prevent against forkbombs by setting an upper bound number of tasks
    in a cgroup. This prevents from a forkbomb to spread. This is typically
    NR_PROC rlimit but in the scope of a cgroup. Traditional NR_PROC doesn't
    help us here because we don't want to have some container starving all the
    others by spawning a high number of tasks when all these containers
    are running under the same user.

    2) Kill safely a cgroup. We want a non-racy and reliable way to kill
    all tasks in a cgroup, without racing against concurrent forks.

    Some practical cases from people who request this can be found here:

    More details on the last patch that provides the documentation.

    = Can that be used by Systemd? =

    Systemd uses cgroups to keep track of services and the processes it
    creates. Some feature have been requested in order to be able to reliably
    kill all the processes in a cgroup such that systemd to kill services without

    (Note I'm not debating here to know if Systemd is doing the right thing by
    using cgroups. I'm just focusing here on this particular feature request).

    The task counter subsystem could be used to solve this problem. However
    this involves the whole task counting machinery and this is too much
    overhead to be used for system services that tend to fork often.

    A simple core latch that rejects forks in a cgroup would be much more efficient
    for this precise purpose.

    = How does it interact with NR_PROC rlimit? =

    Both can be used at the same time. They don't conflict, they
    are just complementary.

    Frederic Weisbecker (7):
    cgroups: add res_counter_write_u64() API
    cgroups: new resource counter inheritance API
    cgroups: ability to stop res charge propagation on bounded ancestor
    res_counter: allow charge failure pointer to be null
    cgroups: pull up res counter charge failure interpretation to caller
    cgroups: allow subsystems to cancel a fork
    cgroups: Add a task counter subsystem

    Kirill A. Shutemov (1):
    cgroups: add res counter common ancestor searching

    Documentation/cgroups/resource_counter.txt | 20 ++-
    Documentation/cgroups/task_counter.txt | 153 ++++++++++++++++
    include/linux/cgroup.h | 20 ++-
    include/linux/cgroup_subsys.h | 8 +
    include/linux/res_counter.h | 27 +++-
    init/Kconfig | 9 +
    kernel/Makefile | 1 +
    kernel/cgroup.c | 23 ++-
    kernel/cgroup_freezer.c | 6 +-
    kernel/cgroup_task_counter.c | 272 ++++++++++++++++++++++++++++
    kernel/exit.c | 2 +-
    kernel/fork.c | 7 +-
    kernel/res_counter.c | 97 +++++++++--
    13 files changed, 612 insertions(+), 33 deletions(-)
    create mode 100644 Documentation/cgroups/task_counter.txt
    create mode 100644 kernel/cgroup_task_counter.c


     \ /
      Last update: 2012-01-13 19:17    [W:0.028 / U:37.216 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site