lkml.org 
[lkml]   [2012]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fs: Fix mod_timer crash when removing USB sticks
On Thu, 12 Jan 2012 14:35:44 -0800
Mandeep Singh Baines <msb@chromium.org> wrote:

> Theodore Tso (tytso@google.com) wrote:
> > On Thu, Jan 12, 2012 at 4:53 PM, Mandeep Singh Baines <msb@chromium.org>wrote:
> >
> > >
> > > Hi Greg,
> > >
> > > What is the conventional way of doing this? There is a lot of good
> > > data in the bug report which might be useful to reviewers. We
> > > couldn't find a de-facto way of referencing the downstream bug database
> > > so we just made up a new field. Sorry. We'll use the correct
> > > field name next time.
> > >
> >
> > There isn't a "correct field name", since it hasn't been standardized. I
> > can tell you as an the ext4 maintainer, I've put things like
> >
> > Addresses-Redhat-Bugzilla: <Bugzilla #>
> >
> > or
> >
> > Addresses-Debian-Bug: <debian-bug-number>
> >
>
> This seems like a good convention. Its also nice in that it scales to
> the case where the bug is reported by multiple distros.
>
> For future, we'll use:
>
> Addresses-ChromiumOS-Bug: http://crosbug.com/<Bug #>
>
> I included the URL because its small and folks might not know where
> our bug database is.

I put "Addresses <some URL>" into the changelog. Just in the text body,
not as one of the tag:value pairs at the end of the changelog.

z:/usr/src/git26> git log | grep "Addresses http" | wc -l
121



\
 
 \ /
  Last update: 2012-01-13 00:25    [W:0.051 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site