Messages in this thread Patch in this message | | | From | Julia Lawall <> | Subject | [PATCH 4/5] drivers/media/video/s5p-mfc/s5p_mfc.c: adjust double test | Date | Thu, 12 Jan 2012 22:49:30 +0100 |
| |
From: Julia Lawall <Julia.Lawall@lip6.fr>
Rewrite a duplicated test to test the correct value
The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/)
// <smpl> @@ expression E; @@
( * E || ... || E | * E && ... && E ) // </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
--- There is an img_height field, so it is my guess that that should be tested instead of testing the img_width field again.
drivers/media/video/s5p-mfc/s5p_mfc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/video/s5p-mfc/s5p_mfc.c b/drivers/media/video/s5p-mfc/s5p_mfc.c index 8be8b54..53126f2 100644 --- a/drivers/media/video/s5p-mfc/s5p_mfc.c +++ b/drivers/media/video/s5p-mfc/s5p_mfc.c @@ -475,7 +475,7 @@ static void s5p_mfc_handle_seq_done(struct s5p_mfc_ctx *ctx, ctx->mv_size = 0; } ctx->dpb_count = s5p_mfc_get_dpb_count(); - if (ctx->img_width == 0 || ctx->img_width == 0) + if (ctx->img_width == 0 || ctx->img_height == 0) ctx->state = MFCINST_ERROR; else ctx->state = MFCINST_HEAD_PARSED;
| |