Messages in this thread | | | Date | Thu, 12 Jan 2012 13:26:29 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] mm: __count_immobile_pages make sure the node is online |
| |
On Thu, 12 Jan 2012 13:35:55 +0100 Michal Hocko <mhocko@suse.cz> wrote:
> On Thu 12-01-12 11:14:15, Mel Gorman wrote: > > On Thu, Jan 12, 2012 at 11:05:21AM +0100, Michal Hocko wrote: > > > Be aware that this is not the version picked up by Andrew. It would > > not hurt to resend as V2 with a changelog and a note saying it replaces > > mm-fix-null-ptr-dereference-in-__count_immobile_pages.patch in mmotm.
They're rather different things? According to the changelogs, mm-fix-null-ptr-dereference-in-__count_immobile_pages.patch fixes a known-to-occur oops. mm-__count_immobile_pages-make-sure-the-node-is-online.patch fixes a bug which might happen in the future if we change the node_zones layut?
So I'm thinking that mm-fix-null-ptr-dereference-in-__count_immobile_pages.patch is 3.3 and -stable material, whereas this patch (mm-__count_immobile_pages-make-sure-the-node-is-online.patch) is 3.3 material. (Actually, it's 3.4 material which I shall stuff into 3.3 because the amount of MM material which we're putting into 3.3 is just off the charts and I fear that 3.4 will be similar)
> > This is just in case the wrong one gets merged due to this thread > > getting lost in the noise of Andrew's inbox.
It won't get lost, but there's a higher-than-usual chance of delays if the patch happens during the merge window: if I see a lengthy patch thread I'll move it into my to-apply folder for consideration later on. So I will look at it, but it might be after the merge window. We can still apply a fix after the merge window of course, but this all might end up leaving buggy code in the tree for longer than we'd like.
| |