lkml.org 
[lkml]   [2012]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC,PATCH 1/2] seccomp_filters: system call filtering using BPF
    On 01/12, Will Drewry wrote:
    >
    > On Thu, Jan 12, 2012 at 10:22 AM, Oleg Nesterov <oleg@redhat.com> wrote:
    > >> +      */
    > >> +     regs = seccomp_get_regs(regs_tmp, &regs_size);
    > >
    > > Stupid question. I am sure you know what are you doing ;) and I know
    > > nothing about !x86 arches.
    > >
    > > But could you explain why it is designed to use user_regs_struct ?
    > > Why we can't simply use task_pt_regs() and avoid the (costly) regsets?
    >
    > So on x86 32, it would work since user_regs_struct == task_pt_regs
    > (iirc), but on x86-64
    > and others, that's not true.

    Yes sure, I meant that userpace should use pt_regs too.

    > If it would be appropriate to expose pt_regs to userspace, then I'd
    > happily do so :)

    Ah, so that was the reason. But it is already exported? At least I see
    the "#ifndef __KERNEL__" definition in arch/x86/include/asm/ptrace.h.

    Once again, I am not arguing, just trying to understand. And I do not
    know if this definition is part of abi.

    Oleg.

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-01-12 18:33    [W:0.026 / U:122.636 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site