lkml.org 
[lkml]   [2012]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] USB: EHCI: Don't use NO_IRQ in xilinx ehci driver
On Thu, 12 Jan 2012, Michal Simek wrote:

> Drivers shouldn't use NO_IRQ. This driver is used
> by Microblaze and PPC. PPC defines NO_IRQ as 0
> and Microblaze has removed it.
>
> Signed-off-by: Michal Simek <monstr@monstr.eu>
> CC: Alan Stern <stern@rowland.harvard.edu>
> CC: Greg Kroah-Hartman <gregkh@suse.de>
> CC: Grant Likely <grant.likely@secretlab.ca>
> CC: linux-usb@vger.kernel.org
> CC: devicetree-discuss@lists.ozlabs.org
> ---
> drivers/usb/host/ehci-xilinx-of.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-xilinx-of.c b/drivers/usb/host/ehci-xilinx-of.c
> index 32793ce..9c2cc46 100644
> --- a/drivers/usb/host/ehci-xilinx-of.c
> +++ b/drivers/usb/host/ehci-xilinx-of.c
> @@ -183,7 +183,7 @@ static int __devinit ehci_hcd_xilinx_of_probe(struct platform_device *op)
> }
>
> irq = irq_of_parse_and_map(dn, 0);
> - if (irq == NO_IRQ) {
> + if (!irq) {
> printk(KERN_ERR "%s: irq_of_parse_and_map failed\n", __FILE__);
> rv = -EBUSY;
> goto err_irq;

Acked-by: Alan Stern <stern@rowland.harvard.edu>



\
 
 \ /
  Last update: 2012-01-12 16:59    [W:0.060 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site