Messages in this thread | | | Date | Wed, 11 Jan 2012 09:35:40 -0800 | From | Dmitry Torokhov <> | Subject | Re: [PATCH v2] input/mc13783-ts: add pdata to set conversion delay |
| |
On Wed, Jan 11, 2012 at 11:49:23AM +0100, Michael Thalmeier wrote: > > +struct mc13xxx_ts_platform_data { > + /* Delay between Touchscreen polarization and ADC Conversion. > + * Given in clock ticks of a 32 kHz clock which gives a granularity of > + * about 30.5ms */ > + char ato; > + > +#define MC13783_TS_ATO_FIRST 0 > +#define MC13783_TS_ATO_EACH 1 > + /* Use the ATO delay only for the first conversion or for each one */ > + char atox; > +};
'char' for these 2 looks wrong, 2 u8, u8 and bool or int and bool would be better.
Otherwise am OK with input bits.
Acked-by: Dmitry Torokhov <dtor@mail.ru>
-- Dmitry
| |