Messages in this thread | | | Date | Wed, 11 Jan 2012 09:30:36 -0800 | From | Tejun Heo <> | Subject | Re: [PATCH 2/9] block: block_bio_complete tracepoint was missing |
| |
Hello,
On Wed, Jan 11, 2012 at 12:25:32PM -0500, Steven Rostedt wrote: > On Tue, 2012-01-10 at 10:28 -0800, Tejun Heo wrote: > > block_bio_complete tracepoint was defined but not invoked anywhere. > > Fix it. > > > > -tj: This will generate duplicate BLK_TA_COMPLETEs. Namhyung is > > working on proper solution. > > > > DO_NOT_APPLY > > Cc: Namhyung Kim <namhyung@gmail.com> > > --- > > fs/bio.c | 3 +++ > > 1 files changed, 3 insertions(+), 0 deletions(-) > > > > diff --git a/fs/bio.c b/fs/bio.c > > index b1fe82c..96548da 100644 > > --- a/fs/bio.c > > +++ b/fs/bio.c > > @@ -1447,6 +1447,9 @@ void bio_endio(struct bio *bio, int error) > > else if (!test_bit(BIO_UPTODATE, &bio->bi_flags)) > > error = -EIO; > > > > + if (bio->bi_bdev) > > + trace_block_bio_complete(bdev_get_queue(bio->bi_bdev), > > + bio, error); > > I thought I commented before about using TRACE_EVENT_CONDITIONAL() here. > To remove that open coded branch.
Yeah but this particular patch is dead now so it's a bit pointless. ioblame:ioblame_io uses it FWIW. Namhyung, can you please consider using TRACE_EVENT_CONDITION() for you patches if applicable?
Thanks.
-- tejun
| |