lkml.org 
[lkml]   [2012]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH TRIVIAL 1/5] Input: keyboard: use macro module_platform_driver()
    Date
    Hi Geert,

    On Tue, 10 Jan 2012 21:57:08 +0100, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
    > On Tue, Jan 10, 2012 at 21:47, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
    >
    > And looking for platform_driver_probe() in recent changesets, I found
    > a few more:
    >
    > drivers/input/touchscreen/atmel-wm97xx.c atmel_wm97xx_probe
    > drivers/input/touchscreen/mc13783_ts.c mc13783_ts_probe
    > drivers/input/serio/at32psif.c psif_probe
    > drivers/input/mouse/amimouse.c amimouse_probe
    >
    > Interestingly, in drivers/input/misc/twl4030-pwrbutton.c you did make
    > platform_driver.probe point to twl4030_pwrbutton_probe().
    > But that one is also broken, as twl4030_pwrbutton_probe() is marked __init,
    > which is no longer correct.
    >
    > Still, setting up platform_driver.probe and removing __init from all probe
    > functions is not the right thing to do, as this make (non-__init) kernel code
    > size bigger, while none of these devices are hotpluggable and thus cannot
    > appear after bootup. That's why we have platform_driver_probe() in the
    > first place. So I think all of this should be reverted for non-hotpluggable
    > drivers.

    Thank you for explaining this.
    I am sorry for the trouble.

    jj

    > Gr{oetje,eeting}s,
    >
    >                         Geert
    >
    > --
    > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
    >
    > In personal conversations with technical people, I call myself a hacker. But
    > when I'm talking to journalists I just say "programmer" or something like that.
    >                                 -- Linus Torvalds
    >
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-01-11 03:21    [W:0.023 / U:29.628 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site