lkml.org 
[lkml]   [2012]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v2 1/3] virtio_net: Split receive buffer alloc/add
    Date
    On Tue, 10 Jan 2012 09:41:01 -0800, Mike Waychison <mikew@google.com> wrote:
    > In preparation for allocating receive buffers in the slow path without
    > disabling NAPI, split the allocation and addition of receive buffers
    > apart into two separate functions (per receive buffer type).
    >
    > While here, move the vi->num accounting into the add functions.
    >
    > Signed-off-by: Mike Waychison <mikew@google.com>

    Hi Mike...

    This exposes a nasty ugliness in the way virtio_net works. We
    allocate an skbuff for the small packet case, and just allocate the
    pages for the large packet cases, and alloc the skbuff when we fill the
    pages.

    I think all the allocators should return a populated skbuff;
    this uses a bit more memory in theory, but should make the code simpler.
    As an added bonus, your life should get much simpler for these patches.

    I'll try to create such a patch tonight, but I'm busy finalizing my
    linux.conf.au presentation, so it might take longer :(

    Thanks,
    Rusty.


    \
     
     \ /
      Last update: 2012-01-11 02:33    [W:0.045 / U:30.716 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site