lkml.org 
[lkml]   [2012]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[19/20] xfs: validate acl count
    2.6.32-longterm review patch.  If anyone has any objections, please let me know.

    ------------------
    From: Christoph Hellwig <hch@infradead.org>

    commit fa8b18edd752a8b4e9d1ee2cd615b82c93cf8bba upstream.

    This prevents in-memory corruption and possible panics if the on-disk
    ACL is badly corrupted.

    Signed-off-by: Christoph Hellwig <hch@lst.de>
    Signed-off-by: Ben Myers <bpm@sgi.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    fs/xfs/linux-2.6/xfs_acl.c | 2 ++
    1 file changed, 2 insertions(+)
    --- a/fs/xfs/linux-2.6/xfs_acl.c
    +++ b/fs/xfs/linux-2.6/xfs_acl.c
    @@ -40,6 +40,8 @@ xfs_acl_from_disk(struct xfs_acl *aclp)
    int count, i;

    count = be32_to_cpu(aclp->acl_cnt);
    + if (count > XFS_ACL_MAX_ENTRIES)
    + return ERR_PTR(-EFSCORRUPTED);

    acl = posix_acl_alloc(count, GFP_KERNEL);
    if (!acl)



    \
     
     \ /
      Last update: 2012-01-10 21:15    [from the cache]
    ©2003-2011 Jasper Spaans