lkml.org 
[lkml]   [2012]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[05/20] offb: Fix bug in calculating requested vram size
    2.6.32-longterm review patch.  If anyone has any objections, please let me know.

    ------------------
    From: Benjamin Herrenschmidt <benh@kernel.crashing.org>

    commit c055fe0797b7bd8f6f21a13598a55a16d5c13ae7 upstream.

    We used to try to request 8 times more vram than needed, which would
    fail if the card has a too small BAR (observed with qemu & kvm).

    Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/video/offb.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)
    --- a/drivers/video/offb.c
    +++ b/drivers/video/offb.c
    @@ -377,7 +377,7 @@ static void __init offb_init_fb(const ch
    int pitch, unsigned long address,
    int foreign_endian, struct device_node *dp)
    {
    - unsigned long res_size = pitch * height * (depth + 7) / 8;
    + unsigned long res_size = pitch * height;
    struct offb_par *par = &default_par;
    unsigned long res_start = address;
    struct fb_fix_screeninfo *fix;



    \
     
     \ /
      Last update: 2012-01-10 21:13    [from the cache]
    ©2003-2011 Jasper Spaans