lkml.org 
[lkml]   [2011]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] sched: share task comm length value to userspace
On Fri, 9 Sep 2011 16:41:30 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:

> if (prctl(PR_GET_NAME, (unsigned long)comm2, 0, 0, 0) < 0) {

Actually, if we were ever to increase sizeof(task_struct.comm),
existing code which does

char comm[16];
prctl(PR_GET_NAME, comm, ...)

will get its stack scribbled on.

So we _could_ increase it, but we'd need to retain the old 16-char
interfaces and add new prctl() modes. And if we did that, we'd design
them in such a way that userspace wouldn't need to assume a fixed
size..



\
 
 \ /
  Last update: 2011-09-10 01:53    [from the cache]
©2003-2011 Jasper Spaans